update otel sdk to v1.16.0/v0.39.0 #2261
Conversation
frzifus
requested review from
iblancasa and
rubenvp8510
and removed request for
iblancasa
|
@frzifus: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
|
hmpf.. still some stuff missing: |
Signed-off-by: Benedikt Bongartz <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: frzifus, iblancasa The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2261 +/- ##
=======================================
Coverage 87.63% 87.63%
=======================================
Files 100 100
Lines 6956 6957 +1
=======================================
+ Hits 6096 6097 +1
Misses 656 656
Partials 204 204
☔ View full report in Codecov by Sentry. |
| } | ||
| observer.ObserveInt64(i.Gauge, int64(count), attrs...) | ||
| opt := metric.WithAttributes( | ||
| attribute.Key(i.Label).String(key), |
There was a problem hiding this comment.
Let me check if that makes sense. Even if, we should rename key I guess ^^
There was a problem hiding this comment.
ok, seems to be the same.
before:
// String creates a KeyValue with a STRING Value type.
func String(k, v string) KeyValue {
return Key(k).String(v)
}After:
func (k Key) String(v string) KeyValue {
return KeyValue{
Key: k,
Value: StringValue(v),
}
}
Which problem is this PR solving?
Fixes the failing CI on:
Short description of the changes
Updating otel sdk:
https://github.com/open-telemetry/opentelemetry-go/releases/tag/v1.16.0